Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditMode - True and wzDisabled with controller variable #210

Closed
DeBiese opened this issue Oct 13, 2016 · 0 comments
Closed

EditMode - True and wzDisabled with controller variable #210

DeBiese opened this issue Oct 13, 2016 · 0 comments

Comments

@DeBiese
Copy link
Contributor

DeBiese commented Oct 13, 2016

When edit-mode is set to true and a step is dynamically enabled/disabled by binding wzdisable, the step will not be set to completed when it becomes enabled.

There are 2 options to fix this in my opinion:
a. Modify $scope.$watch('[editMode, steps.length]' ... to also watch the length of the result of the function call to getEnabledSteps()

b. Modify $scope.$watch('[editMode, steps.length]' ... to not loop through the enabled steps but simply through all the steps.

The more logical choice in my opninion is the second one because in my opinion, when I set edit mode to true, I want all steps in the completed state the moment they are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants