Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Step 5 broken, missing argument #78

Closed
GantMan opened this issue Oct 16, 2013 · 5 comments
Closed

Step 5 broken, missing argument #78

GantMan opened this issue Oct 16, 2013 · 5 comments
Assignees
@btford

Comments

@GantMan
Copy link

GantMan commented Oct 16, 2013

needs the $http parameter.

See my fix here: GantMan/angular-phonecat@angular:step-5...step-5

I can't seem to PR a tag fix.
@ghost ghost assigned btford Oct 17, 2013
@seanfahey
Copy link

Same thing is missing in step 6.

@GantMan
Copy link
Author

GantMan commented Oct 18, 2013

somewhat frustrating I can't figure out the Pull Requests :(

@btford btford closed this as completed Oct 21, 2013
@btford
Copy link
Contributor

btford commented Oct 21, 2013

Pull again, this has since been fixed.

@GantMan
Copy link
Author

GantMan commented Oct 21, 2013

It would be nice to have a way to have fixed this in a PR, is that in the reasonably foreseeable future?
Branches over tags?

@btford
Copy link
Contributor

btford commented Oct 21, 2013

I'm open to concrete suggestions but I can't imagine branches making this type of problem better and not worse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@btford btford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@btford @GantMan @seanfahey