Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Update for changes to Angular CLI 8.0.3 which require clean git status #35

Closed
Splaktar opened this issue Jun 21, 2019 · 3 comments
Closed

Comments

@Splaktar
Copy link
Member

Splaktar commented Jun 21, 2019

angular/angular-cli#14589 (comment) makes a good point. With @clydin’s change to require a clean git status before running ng update, the instructions here need to include at least a mention about committing files between runs of ng update @angular/cli @angular/core and ng update @angular/material.

Another option is to tell users about the --allow-dirty command which will let them otherwise follow this guide w/o issues.

@Splaktar
Copy link
Member Author

Splaktar commented Feb 6, 2020

For version 8.2 to version 9:

  • Run ng update @angular/core@8 @angular/cli@8 in your workspace directory to update to the latest 8.x version of @angular/core and @angular/cli and commit these changes.
  • Run ng update @angular/core @angular/cli --next. This step may require the --force flag if any of your third-party dependencies have not updated the Angular version of their peer dependencies.
  • Your project has now been updated to TypeScript 3.6, read more about new compiler checks and errors that might require you to fix issues in your code.
  • Run ng update @angular/material --next. This step may require the --force flag if any of your third-party dependencies have not updated the Angular version of their peer dependencies.

The first one mentions committing, the second doesn't, thus the 4th will fail due to a dirty workspace if the instructions are followed.

@Splaktar
Copy link
Member Author

Splaktar commented Feb 6, 2020

For version 7 to version 8.2

  • Update to version 8 of the core framework and CLI by running ng update @angular/cli @angular/core in your terminal

...

  • Update Angular Material to version 8 by running ng update @angular/material in your terminal.

There is no mention of the need to commit changes. So a user following the guide will see the update to @angular/material fail due to a dirty workspace.

@StephenFluin
Copy link
Contributor

Fixed in f7c5581

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants