Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Wrong link to ::ng-deep #37

Closed
kubk opened this issue Sep 30, 2019 · 4 comments
Closed

Wrong link to ::ng-deep #37

kubk opened this issue Sep 30, 2019 · 4 comments

Comments

@kubk
Copy link

kubk commented Sep 30, 2019

URL: https://update.angular.io/#7.0:8.0
image

image

This recommendation should refer to this page, not this

The link is correct in recommendation list: https://github.com/StephenFluin/angular-update-guide/blob/ca2753abbad878d231ec13f6f3e2cd9df41e71fb/src/app/recommendations.ts#L61
@Splaktar Splaktar mentioned this issue Oct 1, 2019
Closed
@Niladri24dutta
Copy link

Niladri24dutta commented Oct 4, 2019 •
edited
Loading

@StephenFluin @Splaktar if this is still open can I work on this?

@Splaktar
Copy link
Member

Splaktar commented Oct 4, 2019

@Niladri24dutta yes, please submit a PR 😄

@Niladri24dutta
Copy link

@Niladri24dutta yes, please submit a PR smile

Ok thanks. I am working on my fork.

@dkosasih
Copy link

This is fix with commit 6a00861.
Thanks @bitbruder .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@StephenFluin @Splaktar @Niladri24dutta @dkosasih @kubk