Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

port: ngController #122

Closed
mhevery opened this issue Sep 18, 2013 · 6 comments
Closed

port: ngController #122

mhevery opened this issue Sep 18, 2013 · 6 comments
Milestone

Comments

@mhevery
Copy link
Contributor

mhevery commented Sep 18, 2013

http://docs.angularjs.org/api/ng.directive:ngController

@jbdeboer
Copy link
Contributor

-> remove ngController in favour of components everywhere.

At very least:
-> require the 'as' syntax: fewer options and helps with tooling.

@ghost ghost assigned chirayuk Sep 30, 2013
@mhevery
Copy link
Contributor Author

mhevery commented Sep 30, 2013

Please remove, per our discussion.

@mhevery mhevery closed this as completed in da42129 Oct 1, 2013
@jbdeboer
Copy link
Contributor

jbdeboer commented Oct 1, 2013

Could you remove it from the demo as well?

@jbdeboer jbdeboer reopened this Oct 1, 2013
@andersforsell
Copy link
Contributor

@jbdeboer I like the "controller as" syntax in angularjs, will it not be supported?

@mhevery mhevery closed this as completed in 492eabe Oct 1, 2013
@mhevery
Copy link
Contributor Author

mhevery commented Oct 1, 2013

We are dropping ng-controller="Foo as foo" syntax. The reason is that it is essentially the same as directives in dart.

<div  ng-controller="Foo as foo">
@NgController(name:'Foo')
class Foo {}

now becomes

<div foo-controller>
@NgController(selector:'[foo-controller]', publishAs:'foo')
class Foo {}

No need for differentiating controllers from directives since they are essentially the same now.

@andersforsell
Copy link
Contributor

@mhevery ok, that makes sense.

mhevery added a commit that referenced this issue Oct 1, 2013
mhevery added a commit that referenced this issue Oct 1, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants