Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

Update routing and navigation documentation with correct base href implementation #1035

Closed
user414 opened this issue Apr 1, 2016 · 7 comments

Comments

@user414
Copy link

user414 commented Apr 1, 2016

As described here

angular/angular#4735 (comment)

@Foxandxss
Copy link
Member

Is this still relevant?

/cc @brandonroberts

@user414
Copy link
Author

user414 commented Jul 25, 2016

@Foxandxss I noticed it was changed from the original issue that used / as root reference but we didn't update our code yet to try the new "." root instead. So I'm assuming it is fixed but not sure yet until we try it. Would you rather I close this and reopen if it's still an issue after we migrate to new suggestion?

@Foxandxss
Copy link
Member

Let see what Brandon has to say.

@brandonroberts
Copy link
Contributor

Stick the with / as your base href. Using the . was more meant for plunkers because of the way it sets the base URL for the previews and something like Electron for desktop apps with no server.

@user414
Copy link
Author

user414 commented Jul 25, 2016

@brandonroberts The "/" is the one that causes the problem, as described in original post above. It's a fairly lengthy post but describe well the issue, have a quick look at it.

@brandonroberts
Copy link
Contributor

@user414 I don't think this issue is still relevant is it related to the deprecated router. If the issue still issues with the V3 router, then close the previous issue and open a new one.

@user414
Copy link
Author

user414 commented Jul 25, 2016

@brandonroberts Ok it's possible it was only with the deprecated router. Will close for now, once we have migrated to the new router if it's still an issue will open a new one. Thanks.

@user414 user414 closed this as completed Jul 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants