only call console.log when window.console exists

[lucienbertin]

issue #14006 - window.console only exists in IE 8 & 9 when the devtools are open

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[lucienbertin]

I signed it!

[googlebot]

CLAs look good, thanks!

[googlebot]

CLAs look good, thanks!

[Narretz]

Why not if (window.console)?

[lucienbertin]

that's personal preference. I prefer to test if something is true rather than truthy ; !!window.console is a boolean while window.console is something

I don't think it has any impact on anything so if you prefer if (window.console) i'll change it

[Narretz]

If you are doing !! then you are still relying on console being truthy though

[lucienbertin]

yeah but my if is testing a boolean, not a something that is truthy or falsy

when i read this code

var foo, bar;
...
if (foo) { ... }
if (!!bar) { ... }

I assume foo is a boolean while bar is a something

as i said it's just personal preference

---

fun fact with momentjs, moment.duration(0) is truthy while being equal to 0

moment.duration(0) == 0; // true
moment.duration(0) === 0; // false
!!moment.duration(0); // true
!!0; // false, obviously

[Narretz]

Ideally, we should have an e2e test for this. Do you want to give it a shot? There's a sample e2e test in test/e2e/sample.

[lucienbertin]

I tried for the last 2 hours to make grunt work, following the angular contribute doc but it just don't want to register there is a Gruntfile.js in the dir

I dont know whats causing it, i'll let you handle the e2e test

I'll try to make it work for my next contribution

---

i'm running a command prompt on win 10 as admin and typing

npm install grunt grunt-cli -g
grunt package

and getting

Fatal error: Unable to find local grunt

when the dir cmd gives me

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
... ellipsis...
-a----        2/11/2016   4:36 PM           7170 gdocs.js
-a----        2/11/2016   4:36 PM          10729 Gruntfile.js
-a----        2/11/2016   4:36 PM            610 init-repo.sh
... ellipsis...

I've worked with grunt professionally for the past year, it's not my first walk around the park

[Narretz]

Grunt must be installed without the -g flag. Only grunt-cli must be
installed globally
Am 11.02.2016 19:13 schrieb "lucienbertin" notifications@github.com:

I tried for the last 2 hours to make grunt work, following the angular
contribute doc https://docs.angularjs.org/misc/contribute but it just
don't want to register there is a Gruntfile.js in the dir

I dont know whats causing it, i'll let you handle the e2e test

I'll try to make it work for my next contribution

i'm running a command prompt on win 10 as admin and typing

npm install grunt grunt-cli -g
grunt package

and getting

Fatal error: Unable to find local grunt

when the dir cmd gives me

Mode LastWriteTime Length Name

---

... ellipsis...
-a---- 2/11/2016 4:36 PM 7170 gdocs.js
-a---- 2/11/2016 4:36 PM 10729 Gruntfile.js
-a---- 2/11/2016 4:36 PM 610 init-repo.sh
... ellipsis...

I've worked with grunt professionally for the past year, it's not my first
walk around the park

—
Reply to this email directly or view it on GitHub
#14007 (comment).

[lucienbertin]

> grunt package
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'shelljs'
Warning: Task "package" not found. Use --force to continue.

Aborted due to warnings.

I'm giving up here on the e2e test

also grunt is referenced in package.json so it should get installed when i run npm install, i shouldn't have to run npm install grunt

[Narretz]

Sorry about that. It's possible that the latest node / npm versions are not quite compatible yet with our ancient setup.