This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(angular-loader): do not depend on "closure" globals that may not be available #15881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added a commit
to gkalpak/batarang
that referenced
this pull request
Apr 2, 2017
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see angular#88 for more info). Fixes angular#88
gkalpak
added a commit
to gkalpak/batarang
that referenced
this pull request
Apr 2, 2017
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see angular#88 for more info). Fixes angular#88
gkalpak
added a commit
to gkalpak/batarang
that referenced
this pull request
Apr 2, 2017
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see angular#88 for more info). Fixes angular#88
Narretz
approved these changes
Apr 3, 2017
src/stringify.js
Outdated
| @@ -9,7 +13,10 @@ function serializeObject(obj, maxDepth) { | |||
| // and a very deep object can cause a performance issue, so we copy the object | |||
| // based on this specific depth and then stringify it. | |||
| if (isValidObjectMaxDepth(maxDepth)) { | |||
| obj = copy(obj, null, maxDepth); | |||
| if (!copyFn) { | |||
There was a problem hiding this comment.
Shouldn't angular.copy be always defined here, i.e. at this point in the code, angular.copy should be defined.
src/loader.prefix
Outdated
| function isScope(obj) {return obj && obj.$evalAsync && obj.$watch;} | ||
| function isWindow(obj) {return obj && obj.window === obj;} | ||
| function sliceArgs(args, startIndex) {return Array.prototype.slice.call(args, startIndex || 0);} | ||
| function toJsonReplacer(key, value) { |
There was a problem hiding this comment.
Should we add a note where this and other functions are used? This makes it easier later to check if they are still necessary after refactorings etc.
There was a problem hiding this comment.
You mean add a comment here? Or in the places where these are used?
There was a problem hiding this comment.
In this file - a note at the top is probably enough, saying something of the effect that these functions are defined here because they must be available in angular-loader without angular.js loaded, and that they are copied from the Angular.js file
gkalpak
added a commit
to gkalpak/batarang
that referenced
this pull request
Apr 4, 2017
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see angular#88 for more info). Fixes angular#88
gkalpak
added a commit
to angular/batarang
that referenced
this pull request
Apr 4, 2017
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see #88 for more info). Fixes #88 Closes #311
…be available Code that is distributed as part of both `angular.js` and `angular-loader.js` should not depend on "closure" globals that may not be available in `angular-loader`. Fixes angular#15880
…ay not be available
gkalpak
force-pushed
the
fix-loader-closure-globals
branch
from
59dbff0
to
c7e48c0
Compare
|
Rebased, addressed comments and fixed a bug. Will merge as soon as Travis is happy too. |
|
LGTM. Looks like nobody uses the loader ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
See #15880.
What is the new behavior (if this is a feature change)?
Code that is distributed as part of both
angular.jsandangular-loader.jsdoes not depend on "closure" globals that may not be available inangular-loader.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #15880.