Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($httpParamSerializerJQLike): call functions as jQuery does #16138

Closed
1 of 3 tasks
gkalpak opened this issue Jul 31, 2017 · 3 comments · Fixed by angular-indonesia/angular.js#58 or GulajavaMinistudio/angular.js#54
Closed
1 of 3 tasks

Comments

@gkalpak
Copy link
Member

gkalpak commented Jul 31, 2017

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (see above))

Current behavior:

Function properties are ignored by $httpParamSerializerJQLike().

Expected / new behavior:

Functions should be called and the return value used, the same way jQuery does.

@gkalpak
Copy link
Member Author

gkalpak commented Jul 31, 2017

(Although not necessarily a breaking change (in the sense that this serializer's purpose is to follow jQuery as close as possible), it may break some apps relying on the old, buggy behavior.)

@frederikprijck
Copy link
Contributor

@gkalpak Looking at this we could easily patch

return v;
, but this would affect all other serializers. Is that something u want ?

@gkalpak
Copy link
Member Author

gkalpak commented Jul 31, 2017

No, we only want to affect $httpParamSerializerJQLike.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.