Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add shorthand dependency declaration to allow for minification of angular-mocks #4448

Closed
wants to merge 1 commit into from
Closed

Conversation

hammerdr
Copy link
Contributor

Related to #2250

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

This allows for minification of angular-mocks
@petebacondarwin
Copy link
Member

This was discussed at some length in #3534. I think you will need to provide a strong argument to convince @btford and @pkozlowski-opensource that this is a good idea.

Personally, I think that this change is so simple that whether one feels that minifying ngMocks is a bad thing or not, providing annotated code seems reasonable, both from the point of view of consistency and being nice to people who do want to do this. What is the downside?

@ksheedlo
Copy link
Contributor

I agree with @petebacondarwin on this. There's no downside, and the annotations are useful. Just because we don't provide a minified ngMock on bower or anywhere doesn't mean we can't make it min-safe.

That being said, you probably shouldn't ship ngMockE2E as a fake backend in production like in #2250. It's not intended for that.

@IgorMinar
Copy link
Contributor

let's merge this in. it's harmless. we have no way to test it right now, so if we break it in the future, we'll fix it when someone complains.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Annotation allows the angular-mocks to be minified, which sometimes happens with frameworks that
automatically process files before running tests.
Also, some developers have been using this library in code for their applications.
This is not recommended as the library is only designed to support testing and not production
applications.  If you are likely to want to use the code here in production you would be best
forking and maintaining your own version of the code as we will not guarantee that we won't
break the annotation of the code in the future.

Closes angular#4448
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Annotation allows the angular-mocks to be minified, which sometimes happens with frameworks that
automatically process files before running tests.
Also, some developers have been using this library in code for their applications.
This is not recommended as the library is only designed to support testing and not production
applications.  If you are likely to want to use the code here in production you would be best
forking and maintaining your own version of the code as we will not guarantee that we won't
break the annotation of the code in the future.

Closes angular#4448
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants