This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): rewrite relative paths correctly path==='/' in legacy html5Mode #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… html5Mode Currently, legacy browsers get to use a clever scheme for resolving relative URIs in html5Mode, and resolve the URI relative to $location.path(). Currently, $location.path() can be '/' under certain circumstances, which means that when we split $location.path() on '/' and later join by '/' after adding another path component, we end up with '//pathComponent'. $$rewrite fails to deal with this correctly, and effectively the $location is never changed from the root path. This CL corrects this by ensuring that the duplicate '/' situation does not occur when resolving relative URIs.
|
I'm just trying to get a jsfiddle to work correctly with #8233 landed, and there are a lot of subtle bugs which prevent the bug from actually being fixed (such as this one)... Getting ready to land #8233 btu it's currently blocked on these small things. If tests are green I plan to land this one tonight, TBR=angular-core. |
caitp
added a commit
that referenced
this pull request
Aug 20, 2014
…y html5Mode Currently, legacy browsers get to use a clever scheme for resolving relative URIs in html5Mode, and resolve the URI relative to $location.path(). Currently, $location.path() can be '/' under certain circumstances, which means that when we split $location.path() on '/' and later join by '/' after adding another path component, we end up with '//pathComponent'. $$rewrite fails to deal with this correctly, and effectively the $location is never changed from the root path. This CL corrects this by ensuring that the duplicate '/' situation does not occur when resolving relative URIs. Closes #8684
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, legacy browsers get to use a clever scheme for resolving relative
URIs in html5Mode, and resolve the URI relative to $location.path().
Currently, $location.path() can be '/' under certain circumstances, which
means that when we split $location.path() on '/' and later join by '/' after
adding another path component, we end up with '//pathComponent'. $$rewrite
fails to deal with this correctly, and effectively the $location is never
changed from the root path.
This CL corrects this by ensuring that the duplicate '/' situation does not
occur when resolving relative URIs.