Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Upgrade the whitelist in sanitizer to html 5 #89

Closed
mhevery opened this issue Oct 26, 2010 · 5 comments · Fixed by #613
Closed

Upgrade the whitelist in sanitizer to html 5 #89

mhevery opened this issue Oct 26, 2010 · 5 comments · Fixed by #613
Labels

Comments

@mhevery
Copy link
Contributor

mhevery commented Oct 26, 2010

http://simon.html5.org/html5-elements

@vojtajina
Copy link
Contributor

There are some other tags missing as well, for example h1, h2, ...

@ijonlester
Copy link

I'd be happy to take this up. I've already made the changes in our installation.

@vojtajina
Copy link
Contributor

Awesome ! Let us know, if you need any help...

@ijonlester
Copy link

I made the changes to lib/htmlparser/htmlparser.js and committed them to my fork (ijonlester/angular.js). I left the deprecated tags in (for backward compatibility), added in the HTML5 tags and missing HTML4 tags. In cases where there seemed to be some disagreement whether an element is inline or block, I added it to both (I compared W3Schools HTML5 tag list with the tag lists in the parser and against the list in the OP).

I'm rather new to using github, so I'm not sure how to initiate a pull request. In response to your offer of help, how do I go about requesting a pull?

@vojtajina
Copy link
Contributor

// create new branch
git checkout -b my-fix

// do the changes, tests...

// push the changes to your github
git push origin my-fix

Then go to github web interface, open your branch, e.g.
https://github.com/ijonlester/angular.js/tree/my-fix

And click "PUL REQUEST" - you can find this button in the top right corner...
Fill in some description.. and submit...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants