This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): permit class-based animations for leave operations if ngAnimateChildren is enabled #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngAnimateChildren is enabled Prior to this fix, $animate.leave placed a disabled animation on the element which prevented ngAnimateChildren from properly working. This patch now addresses that issue. Closes angular#8092
matsko
force-pushed
the
class_based_children
branch
from
b52f9df
to
67ce449
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
abdaab7
to
30996f8
Compare
bullgare
pushed a commit
to bullgare/angular.js
that referenced
this pull request
Oct 9, 2014
…ngAnimateChildren is enabled Prior to this fix, $animate.leave placed a disabled animation on the element which prevented ngAnimateChildren from properly working. This patch now addresses that issue. Closes angular#8092 Closes angular#9491
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, $animate.leave placed a disabled animation on the element
which prevented ngAnimateChildren from properly working. This patch now
addresses that issue.
Closes #8092