Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf(ivy): improve NaN checks in change detection (#32212)
This commit drops our custom, change-detection specific, equality comparison util in favour of the standard Object.is which has desired semantics. There are multiple advantages of this approach: - less code to maintain on our end; - avoid NaN checks if both values are equal; - re-write NaN checks so we don't trigger V8 deoptimizations. PR Close #32212
- Loading branch information
1 parent
53f33c1
commit 53bfa7c
Showing
5 changed files
with
5 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1010,9 +1010,6 @@ | |
{ | ||
"name": "isDevMode" | ||
}, | ||
{ | ||
"name": "isDifferent" | ||
}, | ||
{ | ||
"name": "isFactory" | ||
}, | ||
|
This file was deleted.
Oops, something went wrong.