fix(core): fix isComponentView() and isEmbeddedView() tests (#14789)

fixes #14778
angular · Mar 1, 2017 · 5753de5 · 5753de5
1 parent d1182af
commit 5753de5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/modules/@angular/common/test/directives/ng_template_outlet_spec.ts b/modules/@angular/common/test/directives/ng_template_outlet_spec.ts
@@ -34,6 +34,15 @@ export function main() {
       });
     });
 
+    // https://github.com/angular/angular/issues/14778
+    it('should accept the component as the context', async(() => {
+         const template = `<ng-container *ngTemplateOutlet="tpl; context: this"></ng-container>` +
+             `<ng-template #tpl>{{context.foo}}</ng-template>`;
+
+         fixture = createTestComponent(template);
+         detectChangesAndExpectText('bar');
+       }));
+
     it('should do nothing if templateRef is `null`', async(() => {
          const template = `<ng-container [ngTemplateOutlet]="null"></ng-container>`;
          fixture = createTestComponent(template);

diff --git a/modules/@angular/core/src/view/util.ts b/modules/@angular/core/src/view/util.ts
@@ -141,11 +141,11 @@ export function elementEventFullName(target: string, name: string): string {
 }
 
 export function isComponentView(view: ViewData): boolean {
-  return view.component === view.context && !!view.parent;
+  return !!view.parent && !!(view.parentNodeDef.flags & NodeFlags.Component);
 }
 
 export function isEmbeddedView(view: ViewData): boolean {
-  return view.component !== view.context && !!view.parent;
+  return !!view.parent && !(view.parentNodeDef.flags & NodeFlags.Component);
 }
 
 export function filterQueryId(queryId: number): number {