Skip to content

Commit

Permalink
fix(compiler): don't overwrite missingTranslation's value in JIT (#19952
Browse files Browse the repository at this point in the history
)
  • Loading branch information
ocombe authored and vicb committed Nov 3, 2017
1 parent e6f16a7 commit 799cbb9
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/compiler/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ export class CompilerConfig {

constructor(
{defaultEncapsulation = ViewEncapsulation.Emulated, useJit = true, jitDevMode = false,
missingTranslation, enableLegacyTemplate, preserveWhitespaces, strictInjectionParameters}: {
missingTranslation = null, enableLegacyTemplate, preserveWhitespaces,
strictInjectionParameters}: {
defaultEncapsulation?: ViewEncapsulation,
useJit?: boolean,
jitDevMode?: boolean,
Expand All @@ -37,7 +38,7 @@ export class CompilerConfig {
this.defaultEncapsulation = defaultEncapsulation;
this.useJit = !!useJit;
this.jitDevMode = !!jitDevMode;
this.missingTranslation = missingTranslation || null;
this.missingTranslation = missingTranslation;
this.enableLegacyTemplate = enableLegacyTemplate === true;
this.preserveWhitespaces = preserveWhitespacesDefault(noUndefined(preserveWhitespaces));
this.strictInjectionParameters = strictInjectionParameters === true;
Expand Down
19 changes: 19 additions & 0 deletions packages/compiler/test/config_spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/

import {MissingTranslationStrategy} from '@angular/core';
import {CompilerConfig} from '../src/config';

export function main() {
describe('compiler config', () => {
it('should set missing translation strategy', () => {
const config = new CompilerConfig({missingTranslation: MissingTranslationStrategy.Error});
expect(config.missingTranslation).toEqual(MissingTranslationStrategy.Error);
});
});
}

0 comments on commit 799cbb9

Please sign in to comment.