Skip to content

Commit

Permalink
fix(bundles): remove SFX bundle
Browse files Browse the repository at this point in the history
Closes #5665

BREAKING CHANGE:

The existing sfx bundle (angular2.sfx.dev.js) is replaced by UMD bundles:
angular2.umd.js and angular2.umd.dev.js. The new UMD bundles dont have
polyfills (zone.js, reflect-metadata) pre-appended. Those polyfills
can be easily loaded by including the angular-polyfills.js bundle.

Closes #5712
  • Loading branch information
pkozlowski-opensource authored and jelbourn committed Dec 9, 2015
1 parent 0df8bc4 commit a4ba46c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 50 deletions.
25 changes: 0 additions & 25 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -1068,22 +1068,6 @@ gulp.task('!bundle.testing', ['build.js.dev'], function() {
'./dist/js/bundle/testing.js', {sourceMaps: true});
});

// self-executing development build
// This bundle executes its main module - angular2_sfx, when loaded, without
// a corresponding System.import call. It is aimed at ES5 developers that do not
// use System loader polyfills (like system.js and es6 loader).
// see: https://github.com/systemjs/builder (SFX bundles).
gulp.task('!bundle.js.sfx.dev', ['build.js.dev'], function() {
var bundler = require('./tools/build/bundle');

var devBundleConfig = merge(true, bundleConfig);
devBundleConfig.paths = merge(true, devBundleConfig.paths, {'*': 'dist/js/dev/es5/*.js'});

return bundler.bundle(devBundleConfig, 'angular2/angular2_sfx',
'./dist/build/angular2.sfx.dev.js', {sourceMaps: true},
/* self-executing */ true);
});

gulp.task('!bundles.js.umd', ['build.js.dev'], function() {
var q = require('q');
var webpack = q.denodeify(require('webpack'));
Expand Down Expand Up @@ -1197,14 +1181,6 @@ gulp.task('!bundle.js.dev.deps', ['!bundle.js.dev'], function() {
.pipe(gulp.dest('dist/js/bundle'));
});

gulp.task('!bundle.js.sfx.dev.deps', ['!bundle.js.sfx.dev'], function() {
var bundler = require('./tools/build/bundle');

return bundler.modify(JS_DEV_DEPS.concat(['dist/build/angular2.sfx.dev.js']),
'angular2.sfx.dev.js')
.pipe(gulp.dest('dist/js/bundle'));
});

gulp.task('!bundle.web_worker.js.dev.deps', ['!bundle.web_worker.js.dev'], function() {
return merge2(
addDevDependencies("web_worker/ui.dev.js", addDevDependencies("web_worker/worker.dev.js")));
Expand All @@ -1226,7 +1202,6 @@ gulp.task('bundles.js',
'!bundle.js.dev.deps',
'!bundle.js.min.deps',
'!bundle.web_worker.js.dev.deps',
'!bundle.js.sfx.dev.deps',
'bundles.js.umd.min',
'!bundle.testing',
'!bundle.ng.polyfills'
Expand Down
3 changes: 0 additions & 3 deletions modules/angular2/angular2_sfx.dart

This file was deleted.

22 changes: 0 additions & 22 deletions modules/angular2/angular2_sfx.ts

This file was deleted.

0 comments on commit a4ba46c

Please sign in to comment.