fix(http): Headers.append should append to the list

angular · Oct 6, 2016 · a67c067 · a67c067
1 parent d9d57d7
commit a67c067
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/modules/@angular/http/src/headers.ts b/modules/@angular/http/src/headers.ts
@@ -88,7 +88,12 @@ export class Headers {
    */
   append(name: string, value: string): void {
     const values = this.getAll(name);
-    this.set(name, values === null ? [value] : [...values, value]);
+
+    if (values === null) {
+      this.set(name, value);
+    } else {
+      values.push(value);
+    }
   }
 
   /**

diff --git a/modules/@angular/http/test/headers_spec.ts b/modules/@angular/http/test/headers_spec.ts
@@ -111,6 +111,14 @@ export function main() {
     });
 
     describe('.append', () => {
+      it('should append a value to the list', () => {
+        const headers = new Headers();
+        headers.append('foo', 'bar');
+        headers.append('foo', 'baz');
+        expect(headers.get('foo')).toEqual('bar');
+        expect(headers.getAll('foo')).toEqual(['bar', 'baz']);
+      });
+
       it('should preserve the case of the first call', () => {
         const headers = new Headers();