Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(debug): replace DebugElement with new Debug DOM
Now, using `ng.probe(element)` in the browser console returns a DebugElement when in dev mode. `ComponentFixture#debugElement` also returns a new DebugElement. Breaking Change: This is a breaking change for unit tests. The API for the DebugElement has changed. Now, there is a DebugElement or DebugNode for every node in the DOM, not only nodes with an ElementRef. `componentViewChildren` is removed, and `childNodes` is a list of ElementNodes corresponding to every child in the DOM. `query` no longer takes a scope parameter, since the entire rendered DOM is included in the `childNodes`. Before: ``` componentFixture.debugElement.componentViewChildren[0]; ``` After ``` // Depending on the DOM structure of your component, the // index may have changed or the first component child // may be a sub-child. componentFixture.debugElement.children[0]; ``` Before: ``` debugElement.query(By.css('div'), Scope.all()); ``` After: ``` debugElement.query(By.css('div')); ``` Before: ``` componentFixture.debugElement.elementRef; ``` After: ``` componentFixture.elementRef; ```
- Loading branch information
Showing
45 changed files
with
1,233 additions
and
1,210 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 2 additions & 10 deletions
12
modules/angular2/examples/core/debug/ts/debug_element/debug_element.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,8 @@ | ||
import {DebugElement, Scope} from 'angular2/core'; | ||
import {DebugElement} from 'angular2/core'; | ||
|
||
var debugElement: DebugElement; | ||
var predicate; | ||
|
||
// #docregion scope_all | ||
debugElement.query(predicate, Scope.all); | ||
// #enddocregion | ||
|
||
// #docregion scope_light | ||
debugElement.query(predicate, Scope.light); | ||
// #enddocregion | ||
|
||
// #docregion scope_view | ||
debugElement.query(predicate, Scope.view); | ||
debugElement.query(predicate); | ||
// #enddocregion |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
import {By} from 'angular2/platform/browser'; | ||
import {DebugElement, Scope} from 'angular2/core'; | ||
import {DebugElement} from 'angular2/core'; | ||
|
||
var debugElement: DebugElement; | ||
class MyDirective {} | ||
|
||
// #docregion by_all | ||
debugElement.query(By.all(), Scope.all); | ||
debugElement.query(By.all()); | ||
// #enddocregion | ||
|
||
// #docregion by_css | ||
debugElement.query(By.css('[attribute]'), Scope.all); | ||
debugElement.query(By.css('[attribute]')); | ||
// #enddocregion | ||
|
||
// #docregion by_directive | ||
debugElement.query(By.directive(MyDirective), Scope.all); | ||
debugElement.query(By.directive(MyDirective)); | ||
// #enddocregion |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.