Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): StaticReflect now resolves re-exported symbols #10453

Merged
merged 1 commit into from Aug 2, 2016

Conversation

chuckjaz
Copy link
Contributor

@chuckjaz chuckjaz commented Aug 2, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

As described in #10451 the StaticReflector will not correctly locate the metadata for re-exported symbols if the .d.ts file for the symbol was not needed in the ngc invocation.

What is the new behavior?

The Collector now records export declaration information that the StaticReflector uses to track down the correct .metadata.json file that contains the metadata for a re-exported symbol.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Other information:

Fixes: #10451

// Try and find the symbol in the list of explicitly re-exported symbols.
for (const moduleExport of metadata.exports) {
if (moduleExport.export) {
let exportSymbol = moduleExport.export.find(exportSymbol => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const exportSymbol = moduleExport.export.find(symbol ?

@vicb
Copy link
Contributor

vicb commented Aug 2, 2016

LGTM

@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Aug 2, 2016
@chuckjaz chuckjaz merged commit 82e7ecd into angular:master Aug 2, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StaticReflector sometimes cannot find metadata for a symbol
3 participants