Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove module aware bootstrap API #10543

Merged
merged 1 commit into from Aug 8, 2016
Merged

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Aug 5, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[X] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This API was introduced post RC4, but needs to be removed
before RC5 as we have decided against it.

@mhevery mhevery force-pushed the bootstrapJr branch 4 times, most recently from c0bb9a9 to 99adf1e Compare August 6, 2016 05:00
This API was introduced post RC4, but needs to be removed
before RC5 as we have decided against it.
* @experimental This api cannot be used with the offline compiler and thus is still subject to
* change.
* @deprecated This api cannot be used with the offline compiler. Use
* `PlatformRef.boostrapModule()` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in @angular/platform-browser-dynamic, maybe point to the full syntax of platformBrowserDynamic().bootstrapModule() instead?

@alxhub alxhub merged commit d4cceff into angular:master Aug 8, 2016
@mhevery mhevery deleted the bootstrapJr branch June 2, 2017 17:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants