refactor(debug): switch test from TCB to use TestBed #10756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
test_core
branch
2 times, most recently
from
50514d6
to
8d662d7
Compare
IgorMinar
added
pr_state: LGTM
action: cleanup
|
@cnishina can you please rebase? |
cnishina
force-pushed
the
test_core
branch
2 times, most recently
from
fee1611
to
dbae07f
Compare
|
@IgorMinar done. |
juliemr
added
action: review
| Logger, | ||
| ] | ||
| }); | ||
| TestBed.compileComponents(); |
There was a problem hiding this comment.
Remove compileComponents or put inside an async block.
juliemr
added
action: cleanup
|
Same comment as other PR, after that, ready to merge. |
cnishina
force-pushed
the
test_core
branch
2 times, most recently
from
1616f37
to
7797ccf
Compare
|
please squash |
|
Done. |
juliemr
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Refactoring (no functional changes, no api changes)
What is the current behavior? (You can also link to an open issue here)
debug_node_spec uses TestComponentBuilder
What is the new behavior?
Use TestBed
Does this PR introduce a breaking change? (check one with "x")
No