Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Boostrap #10831

Merged
merged 1 commit into from Aug 16, 2016
Merged

Remove Boostrap #10831

merged 1 commit into from Aug 16, 2016

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Aug 15, 2016

No description provided.

@@ -112,8 +109,10 @@ export {QueryEncoder, URLSearchParams} from './src/url_search_params';
* search: string = 'coreTeam=true';
* }
*
* bootstrap(App, [HTTP_PROVIDERS, {provide: RequestOptions, useClass: MyOptions}])
* .catch(err => console.error(err));
* @NgModel({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NgModel -> NgModule

@robwormald
Copy link
Contributor

lgtm with the noted comments

@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Aug 16, 2016
@vsavkin vsavkin added this to the 2.0.0-rc.6 milestone Aug 16, 2016
@vsavkin vsavkin force-pushed the remove_bootstrap branch 3 times, most recently from 0ccec1c to f1873d9 Compare August 16, 2016 03:13
@vikerman vikerman added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 16, 2016
@vikerman
Copy link
Contributor

Travis failing

@vsavkin
Copy link
Contributor Author

vsavkin commented Aug 16, 2016

@vikerman fixed

@vsavkin vsavkin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 16, 2016
@vikerman vikerman merged commit f7ff6c5 into angular:master Aug 16, 2016
hbkrunal pushed a commit to hbkrunal/angular that referenced this pull request Sep 15, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants