rc2 Router strips extra arguments from the path after matching a route

[akorchev]

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

I am trying to implement OAuth2 implicit flow. It redirects to a specified url with a hash appended - #access_token. This is a problem with HashLocationStrategy because it looks for a matching route.
As a workaround I just defined a route that redirects to the root.

{ path: 'access_token', redirectTo: '/' }

Current behavior
In rc2 the router started to strip everything in the URL - for example the value of the access_token.

Expected/desired behavior
In rc1 the router didn't strip anything from the URL and all hashes remained untouched.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

• Angular version: 2.0.0-rc.X
• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
• Language: [all | TypeScript X.X | ES6/7 | ES5]

[zoechi]

Sounds like an issue to compete with #9786

See also 23ee29b

<a [routerLink]="['/user/bob']" preserveQueryParams preserveFragment>

[akorchev]

I see. It makes sense to remove them by default. However there doesn't seem to be a way to specify those options in the route configuration:

{ path: 'auth_token', preserveQueryParams: true, preserveFragment: true }

[vicb]

Your question sounds like a support request.

Please use the issue tracker only for bugs and feature requests.

Use gitter and StackOverflow for support request.

[akorchev]

I wonder why you think this is a support request. There isn't a single question in this issue.

1. Upgrading to angular router rc3 broke existing functionality (OAuth authorization).
2. It turned out to be a fix that has a side effect.
3. I don't think there is any way now to implement OAuth implicit flow login with angular 2 if I use HashLocationStrategy. Of course I can use PathLocationStrategy but then a browser refresh breaks my app (nothing on the server side to handle the route).

[zoechi]

@vicb I also think that adding a config parameter to the route config is a valid feature request.

[MattSenter]

FWIW, I put together a quick and dirty way of ensuring the parameters are always preserved. You just have to override the DefaultUrlSerializer that is configured in the RouterModule.

import {DefaultUrlSerializer} from "@angular/router";
import {UrlTree} from "@angular/router/src/url_tree";

/**
 * Preserves any params passed as part of the hashed route. Normally, these params are annihilated
 * by {DefaultUrlSerializer}, but that is dumb because it prevents things like OAuth2 Implicit
 * grants from succeeding.
 */
export class PreserveHashParamsUrlSerializer extends DefaultUrlSerializer {

  parse(url: string): UrlTree {
    console.debug("[PreserveHashParamsUrlSerializer] Parsing url=" + url);
    let preservedHashParamsUrl = url.replace("&", "?");
    console.debug("[PreserveHashParamsUrlSerializer] Now preservedHashParamsUrl=" + preservedHashParamsUrl);
    return super.parse(preservedHashParamsUrl);
  }
}

Then of course in your app-routing.module.ts or what-have-you, you need to provide PreserveHashParamsUrlSerializer.

...
@NgModule({
  imports: [RouterModule.forRoot(routes, {useHash: true})],
  exports: [RouterModule],
  providers: [
    {provide: UrlSerializer, useClass: PreserveHashParamsUrlSerializer}
  ]
})
...

Note that I am using Angular 5 at this point. Not sure why this isn't a configurable thing.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}