style(CompileMetadataResolver): better error message #11401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -307,7 +307,7 @@ export class CompileMetadataResolver { | |||
| const typeMetadata = flattenArray(meta.bootstrap).map(type => { | |||
| if (!isValidType(type)) { | |||
| throw new Error( | |||
| `Unexpected value '${stringify(type)}' used in the bootstrap property of module '${stringify(moduleType)}'`); | |||
| `Unexpected value '${stringify(type)}' used in the bootstrap property of module '${stringify(moduleType)}'`);p | |||
vicb
added
the
action: cleanup
| @@ -377,7 +377,7 @@ export class CompileMetadataResolver { | |||
| const oldModule = this._ngModuleOfTypes.get(type); | |||
| if (oldModule && oldModule !== moduleType) { | |||
| throw new Error( | |||
| `Type ${stringify(type)} is part of the declarations of 2 modules: ${stringify(oldModule)} and ${stringify(moduleType)}!`); | |||
| `Type ${stringify(type)} is part of the declarations of 2 modules: ${stringify(oldModule)} and ${stringify(moduleType)}! Please consider moving ${stringify(type)} to a higher module that imports ${stringify(oldModule)} and ${stringify(moduleType)}. You can also create a new NgModule that exports and includes ${stringify(type)} then import that NgModule in ${stringify(oldModule)} and ${stringify(moduleType)}.`); | |||
There was a problem hiding this comment.
Please consider splitting the msg over multiple lines & squash the commits. Thanks
|
@vicb all green |
|
thanks Patrick |
vicb
added
pr_state: LGTM
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.