Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): mark TestBed as stable api and add preliminary docs #11767

Merged
merged 1 commit into from Sep 22, 2016

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar added compX: docs action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2016
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the CI please

@@ -47,7 +47,12 @@ export type TestModuleMetadata = {
};

/**
* @experimental
* @whatItDoes Configures and initializes environment for unit testing and provides methods for creating components and services in unit tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@IgorMinar IgorMinar force-pushed the testbed-stable branch 2 times, most recently from d988da0 to d411b8e Compare September 20, 2016 21:05
*
* TestBed is the primary api for writing unit tests for Angular applications and libraries.
*
* @stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the public api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh. I did, but incorrectly. hopefully it's fixed now.

TestBed was accidentaly ommited from the 'stable' api list during the API sweep before final. We do consider it to be stable.
@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2016
@rkirov rkirov merged commit 3a6fcee into angular:master Sep 22, 2016
IgorMinar added a commit that referenced this pull request Sep 23, 2016
TestBed was accidentaly ommited from the 'stable' api list during the API sweep before final. We do consider it to be stable.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants