refactor(compiler): attribute ast records span of the value #12132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
added
the
action: review
vicb
reviewed
Oct 6, 2016
| const ast = parser.parse('<div bar="12"></div>', 'TestComp'); | ||
| const attr = (ast.rootNodes[0] as html.Element).attrs[0]; | ||
| expect(attr.valueSpan.start.offset).toEqual(9); | ||
| expect(attr.valueSpan.end.offset).toEqual(13); |
There was a problem hiding this comment.
nit: expect(attr.valueSpan.toString()).toEqual('12') ?
There was a problem hiding this comment.
I prefer the direct comparison to a number than converting to a string.
vicb
added
pr_state: LGTM
and removed
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The
Attributeclass of the HTML AST does not record where the value is the source. This information is needed in the language service.What is the new behavior?
The
Attributeclass records the span of the value of the attribute if the attribute has a value.Does this PR introduce a breaking change? (check one with "x")