-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOT generated scss.shim imported path && scss brackets bugs #12539
Comments
Hi. Can u pls provide a minimal repository with reproduction? |
Also, how are you running the SCSS compilation? do your components point to |
@DzmitryShylovich I will try to make a demo, but I don't think aot files could be generated online, the component code is: |
@robwormald @DzmitryShylovich I know why now, I use scss in styleUrls, and with webpack sass-loader, app runs well in JIT mode using webpack. In AOT mode, I have to run ngc command first, and ngc compiled scss files to scss.shim.ts directly without any scss compilation. The scss.shim.ts include path is wrong, also In scss.shim.ts scss grammer exists(I thought 'shim' means scss is compiled). |
@zhaxi does it means this issue can be closed ? |
@vicb , I think it's a bug, cause ngc realize scss is style files, and add shim to scss files, but the include path and style code are not correct. |
This is a dupe of #11688 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ... (check one with "x")
Current behavior
Following angular.io docs:
Using node_modules/.bin/ngc command to generate AOT code into /aot dir,
Include Path Bugs:
For example in home.ngfatory.ts it shows :
Actually the structure in AOT dir is:
The structure in App dir is :
SCSS brackets bugs:
In AOT mode, styles became a mess,
in component.scss.shim shows:


It has a pair of needless brackets compared to JIT mode, if I delete the brackets in head styles,all became normal
Expected behavior
SCSS Include expected behavior
SCSS brackets expected behavior
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
AOT shows the same as JIT mode
Please tell us about your environment:
MacOS Serria, Visual Studio Code, NPM
The text was updated successfully, but these errors were encountered: