perf(EventManager): Event subscription speedup using Plugin cache #12824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dom events plugin is last in list of plugins, therefore each subscription goes through .supports calls unnecessarily after the first lookup. This change caches them to efficiently bypass the search.
vicb
added
action: merge
vicb
pushed a commit
to vicb/angular
that referenced
this pull request
Nov 12, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
On every event subscription, event manager searches all plugins.
Dom events plugin is last in list of plugins, therefore each subscription goes through .supports(eventName) calls unnecessarily after the first lookup. This change caches them to efficiently bypass the search.
What is the new behavior?
Once we know which plugin serves an event type, it is cached.
Does this PR introduce a breaking change? (check one with "x")