fix(http): correctly handle response body for 204 status code #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzmitryShylovich
force-pushed
the
gh/12393
branch
2 times, most recently
from
367c741
to
b49603c
Compare
vicb
reviewed
Nov 12, 2016
| @@ -239,7 +239,7 @@ export declare class XHRConnection implements Connection { | |||
| request: Request; | |||
| response: Observable<Response>; | |||
| constructor(req: Request, browserXHR: BrowserXhr, baseResponseOptions?: ResponseOptions); | |||
| setDetectedContentType(req: any, _xhr: any): void; | |||
There was a problem hiding this comment.
please refrain from changing the types - add a // TODO: ... in the code (and open a meta issue "[3.0] Adding/fixing types" referencing the place where we should update). Thanks !
vicb
reviewed
Nov 12, 2016
| @@ -5,15 +5,13 @@ | |||
| * Use of this source code is governed by an MIT-style license that can be | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
could you please leave a blank line here
vicb
added
comp: http
action: review
DzmitryShylovich
force-pushed
the
gh/12393
branch
from
b49603c
to
1b5c7bf
Compare
vicb
reviewed
Nov 12, 2016
| @@ -137,7 +148,7 @@ export class XHRConnection implements Connection { | |||
| }); | |||
| } | |||
|
|
|||
| setDetectedContentType(req: any /** TODO #9100 */, _xhr: XMLHttpRequest) { | |||
| setDetectedContentType(req: any /** TODO #9100 */, _xhr: any /** TODO #9100 */) { | |||
vicb
reviewed
Nov 12, 2016
| async.done(); | ||
| }); | ||
|
|
||
| existingXHRs[0].setStatusCode(statusCode); |
There was a problem hiding this comment.
would this have failed before ?
should you add an explicit body ?
vicb
reviewed
Nov 12, 2016
| // normalize IE9 bug (http://bugs.jquery.com/ticket/1450) | ||
| let status: number = _xhr.status === 1223 ? 204 : _xhr.status; | ||
|
|
||
| let body: any = null; | ||
|
|
||
| // 204 is not supposed to have any response body |
There was a problem hiding this comment.
nit: change to // HTTP 204 means no content
vicb
added
action: cleanup
DzmitryShylovich
force-pushed
the
gh/12393
branch
3 times, most recently
from
31a4c12
to
17d354a
Compare
vicb
added
action: merge
DzmitryShylovich
force-pushed
the
gh/12393
branch
from
17d354a
to
493c1b2
Compare
chuckjaz
pushed a commit
that referenced
this pull request
Nov 17, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12393