Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): fix error when running test.sh #12927

Merged
merged 1 commit into from Nov 16, 2016

Conversation

chuckjaz
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

Running ./test.sh node produces an error in @angular/examples/upgrade/static/ts/module.ts.

The example requires the angularjs type description which is not provided by tsconfig.json in the modules directory.

What is the new behavior?

Running ./test.sh no longer produces an error in the upgrade example because it is excluded from the build.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@petebacondarwin
Copy link
Member

This works better for me.

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker and removed cla: yes labels Nov 16, 2016
@chuckjaz chuckjaz merged commit f340e1a into angular:master Nov 16, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants