Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js2dart: add library into every dart file #12

Closed
tbosch opened this issue Sep 25, 2014 · 2 comments
Closed

js2dart: add library into every dart file #12

tbosch opened this issue Sep 25, 2014 · 2 comments

Comments

@tbosch
Copy link
Contributor

tbosch commented Sep 25, 2014

In file path/dom.dart:

Add header

library path.dom;
@tbosch
Copy link
Contributor Author

tbosch commented Sep 25, 2014

First implementation working, needs clean up: https://github.com/angular/angular/blob/master/tools/js2dart/src/compiler.js#L31

@vicb vicb mentioned this issue Sep 26, 2014
Closed
@vicb vicb closed this as completed in 2cc1a4c Sep 26, 2014
@kzhdev kzhdev mentioned this issue Jun 13, 2015
Closed
@TedSander TedSander mentioned this issue Jun 18, 2015
Closed
@avoivo avoivo mentioned this issue Jul 31, 2015
Closed
@vikerman vikerman mentioned this issue Aug 26, 2015
Closed
@vikerman vikerman mentioned this issue Sep 5, 2015
Closed
vsavkin pushed a commit to vsavkin/angular that referenced this issue Jun 20, 2016
@dloukadakis @vsavkin
fix(router): port fixes done on angular current router to the new one
da845ad 
The bugs were fixed on current angular router in the following commits:
angular/angular@b2a7fd0
angular/angular@fa2ce81
angular/angular@595bcdd

Closes angular#12
vsavkin pushed a commit to vsavkin/angular that referenced this issue Jun 21, 2016
@dloukadakis @vsavkin
fix(router): port fixes done on angular current router to the new one
a13d8c6 
The bugs were fixed on current angular router in the following commits:
angular/angular@b2a7fd0
angular/angular@fa2ce81
angular/angular@595bcdd

Closes angular#12
vsavkin pushed a commit that referenced this issue Jun 21, 2016
@dloukadakis @vsavkin
fix(router): port fixes done on angular current router to the new one
9a67f38 
The bugs were fixed on current angular router in the following commits:
b2a7fd0
fa2ce81
595bcdd

Closes #12
@supposedly supposedly mentioned this issue Dec 21, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(js2dart): refactor dart library statement
2 participants
@vicb @tbosch