Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): fix paths in source maps to be relative #13042

Closed
wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

The change looks bigger than it really is because I reordered the properties to match other tsconfigs we have.

The only real change is removal of sourceRoot property.

Fixes #13040

@IgorMinar IgorMinar added area: packaging Issues related to Angular's creation of npm packages action: review The PR is still awaiting reviews from at least one requested reviewer type: bug/fix labels Nov 22, 2016
The change looks bigger than it really is because I reordered the properties to match other tsconfigs we have.

The only real change is removal of sourceRoot property.

Fixes angular#13040
@alxhub
Copy link
Member

alxhub commented Nov 22, 2016

LGTM

@alxhub alxhub added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 22, 2016
@vsavkin
Copy link
Contributor

vsavkin commented Nov 24, 2016

Merged 2a3ca7b

@vsavkin vsavkin closed this Nov 24, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: packaging Issues related to Angular's creation of npm packages cla: yes type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/compiler-cli source maps leak username
4 participants