fix(language-service): do not throw for invalid metadata #13261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
added
action: review
chuckjaz
force-pushed
the
issue13255
branch
2 times, most recently
from
84eb399
to
5499591
Compare
chuckjaz
added
action: review
vicb
reviewed
Dec 6, 2016
| this._reportError( | ||
| new Error( | ||
| `Unexpected value '${stringify(importedType)}' imported by the module '${stringify(moduleType)}'`), | ||
| moduleType); |
There was a problem hiding this comment.
return ? (in case some code is added below)
vicb
reviewed
Dec 6, 2016
| new Error( | ||
| `Unexpected value '${stringify(type)}' used in the bootstrap property of module '${stringify(moduleType)}'`), | ||
| moduleType); | ||
| return; |
There was a problem hiding this comment.
The return is intentional to avoid the push below.
There was a problem hiding this comment.
Yep seen that after (I first thought you wanted to break the loop)
|
LGTM with a few minor comments |
vicb
added
pr_state: LGTM
and removed
action: review
|
Hi @chuckjaz, Can you rebase? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The language service will sometimes throw with invalid metadata.
#13255
What is the new behavior?
The language service no longer throws.
Does this PR introduce a breaking change? (check one with "x")
Other information:
Fixes #13255