Metadata format 3 #13464
Merged
Metadata format 3 #13464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
Dec 14, 2016
| const componentMetadata = metadata.metadata['MyComponent']; | ||
|
|
||
| // Get the first argument of the decorator call which is passed to @Component | ||
| expect(isClassMetadata(componentMetadata)).toBeTruthy(); |
There was a problem hiding this comment.
maybe extract into a helper function?
|
Some collector tests are still failing... |
chuckjaz
force-pushed
the
metadata-format-3
branch
from
5d02775
to
4dacff5
Compare
This change retracts support for metadata version 2. The collector used to produce version 2 metadata was incomplete and can cause the AOT compiler to fail to resolve symbols or produce other spurious errors. All libraries compiled and published with 2.3.0 ngc will need to be recompiled and updated with this change.
chuckjaz
force-pushed
the
metadata-format-3
branch
from
4dacff5
to
2a119c7
Compare
vicb
pushed a commit
that referenced
this pull request
Dec 15, 2016
This change retracts support for metadata version 2. The collector used to produce version 2 metadata was incomplete and can cause the AOT compiler to fail to resolve symbols or produce other spurious errors. All libraries compiled and published with 2.3.0 ngc will need to be recompiled and updated with this change.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
Various errors in the collection of version 2 format requires a version format change to fix.
What is the new behavior?
The updates the metadata format produced by the collector and required by the static reflector to version 3.
Does this PR introduce a breaking change? (check one with "x")
Other information:
Version 1 is still supported and is auto-upgraded to format 3 by the
CompilerHostin thecompiler-cli.