test(forms): refactor integration tests to improve speed #13500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
force-pushed
the
formsTestRefactor
branch
from
db88879
to
ccf1cc1
Compare
marclaval
added
the
action: review
vicb
reviewed
Dec 15, 2016
| ] | ||
| }); | ||
| }); | ||
| function initTest(...args: any[]): ComponentFixture<any> { |
There was a problem hiding this comment.
(component: Type, ...directives: Type[])
There was a problem hiding this comment.
function initTest<T>(component: Type<T>, ...directives: Type[]): ComponentFixture<T> could be even better.
vicb
added
action: cleanup
marclaval
force-pushed
the
formsTestRefactor
branch
2 times, most recently
from
17f4bda
to
54e4c49
Compare
marclaval
force-pushed
the
formsTestRefactor
branch
from
54e4c49
to
4ddc56a
Compare
marclaval
added
action: merge
|
I believe router has the same issue https://github.com/angular/angular/blob/master/modules/%40angular/router/test/integration.spec.ts |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating browser disconnections in SauceLabs, I found out that the forms integration test were quite slow and CPU intensive.
Using
TestBed.configureTestingModule()for all components inbeforeEach()is clearly not ideal.These 130 tests were taking 13s to run on my machine.
With these changes,the only take 4s!!!
As a result, the full campaign goes from 43s to 34s.
Hopefully, this will also help with the disconnections.
But it might not be enough ...