fix(upgrade): fix registerForNg1Tests
#13522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When trying the example in for
UpgradeAdapter#registerForNg1Tests
, it crashes with the following exception:This is because
upgrade.ng1Injector
passed to_bootstrapDone
inregisterForNg1Tests
is null.What is the new behavior?
UpgradeAdapter#registerForNg1Tests
doesn't throw the above exception anymore.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Fix an issue in
registerForNg1Tests
, where it passes anull
asng1Injector
to_bootstrapDone
. This causes a "TypeError: Cannotread property 'get' of null" to be thrown from
_bootstrapDone
.