feat(compiler): generate proper reexports in .ngfactory.ts file…
#13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
force-pushed
the
gen_reexport
branch
8 times, most recently
from
9a25fec
to
c402ab2
Compare
tbosch
commented
Dec 21, 2016
| @@ -21,5 +21,6 @@ export interface PlatformReflectionCapabilities { | |||
| method(name: string): MethodFn; | |||
| importUri(type: Type<any>): string; | |||
| resolveIdentifier(name: string, moduleUrl: string, runtime: any): any; | |||
| getIdentifier(name: string, filePath: string, runtime: any): any; | |||
There was a problem hiding this comment.
Remove this, pass SaticSymbolCache to CompileMetadataResolver
tbosch
commented
Dec 21, 2016
| @@ -42,6 +42,9 @@ export class StaticAndDynamicReflectionCapabilities { | |||
| setter(name: string): SetterFn { return this.dynamicDelegate.setter(name); } | |||
| method(name: string): MethodFn { return this.dynamicDelegate.method(name); } | |||
| importUri(type: any): string { return this.staticDelegate.importUri(type); } | |||
| getIdentifier(name: string, filePath: string, runtime: any): any { | |||
tbosch
commented
Dec 21, 2016
| if (!name) { | ||
| return null; | ||
| } | ||
| let filePath: string; | ||
| let isFunctionParam: boolean; |
tbosch
commented
Dec 21, 2016
| if (!isFunctionParam) { | ||
| filePath = sourceSymbol.filePath; | ||
| if (topLevelSymbolNames.has(name)) { |
There was a problem hiding this comment.
move logic below into here, i.e. use early returns as well.
tbosch
commented
Dec 21, 2016
|
|
||
| // Remove extra underscore from escaped identifier | ||
| export function unescapeIdentifier(identifier: string): string { | ||
| return identifier.length >= 3 && identifier.charCodeAt(0) === UNDERSCORE_CHAR_CODE && |
There was a problem hiding this comment.
Maybe use startsWith('___')?
tbosch
commented
Dec 21, 2016
| @@ -70,7 +87,13 @@ export class AotSummaryResolver implements SummaryResolver<StaticSymbol> { | |||
| } | |||
| if (json) { | |||
| const readSummaries = deserializeSummaries(this.staticSymbolCache, json); | |||
There was a problem hiding this comment.
destructure immediately
tbosch
commented
Dec 21, 2016
| summaries: this.processedSummaries, | ||
| symbols: this.symbols.map((symbol, index) => { | ||
| let importAs: string; | ||
| if (this.summaryResolver.isLibraryFile(symbol.filePath)) { | ||
| importAs = `${symbol.name}${index}`; |
There was a problem hiding this comment.
Add _ in between name and index?
tbosch
commented
Dec 21, 2016
| try { | ||
| this._directiveResolver.resolve(directiveType, false); | ||
| } catch (e) { | ||
| console.error('>>>>', directiveType); |
tbosch
commented
Dec 21, 2016
| @@ -20,8 +20,7 @@ import {NgModuleProviderAnalyzer} from './provider_analyzer'; | |||
| import {ProviderAst} from './template_parser/template_ast'; | |||
|
|
|||
| export class ComponentFactoryDependency { | |||
There was a problem hiding this comment.
Add a comment that this is not read any more, but we migth need it for later features.
tbosch
commented
Dec 21, 2016
| constructor( | ||
| public comp: CompileIdentifierMetadata, public name: string, | ||
| public placeholder: CompileIdentifierMetadata) {} | ||
| export class ComponentViewDependency { |
There was a problem hiding this comment.
Add comment that these are not used right now but migth be in the future
tbosch
commented
Dec 21, 2016
| serialize([{symbol: srcSymbol, metadata: 1}, {symbol: libSymbol, metadata: 2}], []) | ||
| }); | ||
| summaryResolver.getSymbolsOf('/src.d.ts'); | ||
| expect(summaryResolver.getImportAs(libSymbol)) |
There was a problem hiding this comment.
Check that we don't have an importAs for srcSymbol
tbosch
added
action: cleanup
|
Reviewed in person with @vicb |
tbosch
removed
the
action: cleanup
tbosch
changed the title
.ngfactory.ts file….ngfactory.ts file…
… not need transitive deps for compiling `.ngfactory.ts` files. Note: This checks the constructors of `@Injectable` classes more strictly. E.g this will fail now as the constructor argument has no `@Inject` nor is the type of the argument a DI token. ``` @Injectable() class MyService { constructor(dep: string) {} } ``` Last part of angular#12787 Closes angular#12787
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge, this needs cl/142263969, cl/142784802, plus a run of
release_tsc.shin G3.Global presubmit is green (besides flakes).