Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bower instructions in DEVELOPER.md #13591

Merged
merged 2 commits into from
Dec 21, 2016
Merged

Include bower instructions in DEVELOPER.md #13591

merged 2 commits into from
Dec 21, 2016

Conversation

RyanCavanaugh
Copy link
Contributor

@RyanCavanaugh RyanCavanaugh commented Dec 20, 2016

Failing to run this step results in an error

====== Copying files needed for benchmarks =====
ln: failed to create symbolic link './polymer': No such file or directory

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Docs fix

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Failing to run this step results in an error
```ts
====== Copying files needed for benchmarks =====
ln: failed to create symbolic link './polymer': No such file or directory
```
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@RyanCavanaugh
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Now run `bower` to install additional dependencies:

```shell
# Install other Angular project dependencies (package.json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bower.json

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Dec 21, 2016
@chuckjaz chuckjaz merged commit bcd37f5 into angular:master Dec 21, 2016
@RyanCavanaugh RyanCavanaugh deleted the patch-2 branch December 21, 2016 02:34
chuckjaz pushed a commit to chuckjaz/angular that referenced this pull request Dec 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants