build: fix publish-build-artifacts branch detection #13599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The changes introduced in #13529 pass locally but fail on travis.
More specifically, branch detection in
BRANCH=
git rev-parse --abbrev-ref HEADresults in
BRANCH=HEADinstead of
BRANCH=master` in https://travis-ci.org/angular/angular/jobs/185615697#L2214, which breaks the publishing process further down the script execution.What is the new behavior?
This PR introduces an alternative mechanism for determining the current branch:
It will first check for
TRAVIS_BRANCH
and if not present, determine the branch via a newer git mechanism.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
/cc @chuckjaz