Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix publish-build-artifacts branch detection #13599

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Dec 20, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The changes introduced in #13529 pass locally but fail on travis.

More specifically, branch detection in BRANCH=git rev-parse --abbrev-ref HEADresults inBRANCH=HEADinstead ofBRANCH=master` in https://travis-ci.org/angular/angular/jobs/185615697#L2214, which breaks the publishing process further down the script execution.

What is the new behavior?
This PR introduces an alternative mechanism for determining the current branch:

BRANCH=${TRAVIS_BRANCH:-$(git symbolic-ref --short HEAD)}

It will first check for TRAVIS_BRANCH and if not present, determine the branch via a newer git mechanism.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

/cc @chuckjaz

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Dec 20, 2016
@chuckjaz chuckjaz merged commit 9b8488f into angular:master Dec 20, 2016
chuckjaz pushed a commit to chuckjaz/angular that referenced this pull request Dec 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants