Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform-browser): disable console.log error for log() #13601

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

chuckjaz
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

[x] Refactoring (no functional changes, no api changes)

What is the current behavior? (You can also link to an open issue here)

Fails tslint

What is the new behavior?

Passes tslint

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@chuckjaz chuckjaz added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 21, 2016
@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 21, 2016
@vicb vicb added this to the lgtm milestone Dec 21, 2016
@vicb vicb added action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Dec 21, 2016
@DzmitryShylovich
Copy link
Contributor

already disabled it here ba87788

@chuckjaz
Copy link
Contributor Author

chuckjaz commented Dec 21, 2016

Yes but a subsequent PR added this line. This removes it again. This should have been a noop but tslint doesn't handle this case correctly and if you add a one-line disable it will unconditionally re-enable the check instead of reverting to the prior state.

@chuckjaz chuckjaz merged commit e69c1fb into angular:master Dec 21, 2016
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Dec 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants