chore(tslint): update tslint to 4.x #13603
Conversation
vicb
added
action: review
|
This doesn't appear to work on CircleCI |
vicb
force-pushed
the
1220-tslint
branch
5 times, most recently
from
75cf30e
to
2dbc1b8
Compare
|
@chuckjaz PTAL |
| @@ -11,7 +11,7 @@ import {NgZone} from '@angular/core'; | |||
| import {global} from './facade/lang'; | |||
| import {getDOM} from './private_import_platform-browser'; | |||
|
|
|||
| export let browserDetection: BrowserDetection = new BrowserDetection(null); | |||
| let browserDetection: BrowserDetection = new BrowserDetection(null); | |||
There was a problem hiding this comment.
This breaks the file because classes cannot be used before they are declared (probably worked only as a side-effect of how the export was generated). To fix, remove the initializer as it is redundant with the the call to setup() on line 75.
vicb
force-pushed
the
1220-tslint
branch
2 times, most recently
from
cc1bcf1
to
c676bfe
Compare
|
@chuckjaz PTYAL |
| @@ -135,6 +135,10 @@ export function stringifyElement(el: any /** TODO #9100 */): string { | |||
| return result; | |||
| } | |||
|
|
|||
| browserDetection = new BrowserDetection(null); | |||
There was a problem hiding this comment.
Why is this necessary? Line 75 contains BrowserDetection.setup(); for which setup() is browserDetection = new BrowserDetection(null); Why do we create two?
chuckjaz
added
pr_state: LGTM
and removed
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@chuck I did clone tslint, fix the issue and send a PR and then I realize I started from the wrong repo and that it was already fixed in the parent repo.
Anyway this PR should remove the bug.