fix(Compiler): allow "." in attribute selectors #13653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added
area: core
tbosch
reviewed
Dec 22, 2016
| templateBindingsSource = attr.value; | ||
| } else if (attr.name.startsWith(TEMPLATE_ATTR_PREFIX)) { | ||
| } else if (normalizedName.startsWith(TEMPLATE_ATTR_PREFIX)) { |
tbosch
reviewed
Dec 22, 2016
| @@ -623,6 +623,23 @@ Binding to attribute 'onEvent' is disallowed for security reasons ("<my-componen | |||
| ]); | |||
| }); | |||
|
|
|||
| it('should parse directive dotted properties', () => { | |||
There was a problem hiding this comment.
Add a full integration tests as well that also tests that we write the value into the property.
tbosch
reviewed
Dec 22, 2016
| classes?: string} = {}): CssSelector { | ||
| const classAttr: [string, string] = ['class', classes]; | ||
| attrs.push(classAttr); | ||
| return createElementCssSelector(tag, attrs); |
There was a problem hiding this comment.
Copy simplified version of createElementCssSelector into this spec (e.g. without namespace handling, ...)
tbosch
added
action: cleanup
vicb
added
action: merge
| const template = `<div [dot.name]="'foo'"></div>`; | ||
| fixture = createTestComponent(template); | ||
| fixture.detectChanges(); | ||
| const myDir = fixture.debugElement.query(By.directive(MyDir)).injector.get(MyDir); |
There was a problem hiding this comment.
I did not know you could do this! Cool technique.
| import {expect} from '@angular/platform-browser/testing/matchers'; | ||
|
|
||
| export function main() { | ||
| describe('integration tests', () => { |
There was a problem hiding this comment.
Really glad to see this test. Makes it very clear. Thx.
| expect(humanizeTplAst(parse('<div [dot.name]="expr"></div>', [dirA]))).toEqual([ | ||
| [ElementAst, 'div'], | ||
| [DirectiveAst, dirA], | ||
| [BoundDirectivePropertyAst, 'localName', 'expr'], |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13645