Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): do not create a blob out of ArrayBuffer when type is application/octet-stream #13992

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Jan 18, 2017

Closes #13973

I'd like the proposed solution

 case 'application/octet-stream':
      default:
        return this.detectContentTypeFromBody();

but it will be a breaking change. This test will fail.

@mhevery mhevery requested a review from alxhub January 18, 2017 18:16
@mhevery mhevery merged commit 1200cf2 into angular:master Jan 19, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/13973 branch January 19, 2017 00:03
mhevery pushed a commit that referenced this pull request Jan 19, 2017
wKoza pushed a commit to wKoza/angular that referenced this pull request Feb 12, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http should not create a blob out of ArrayBuffer
3 participants