Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): fix regexp to support firefox 31 #14082

Merged
merged 1 commit into from
Jan 24, 2017
Merged

fix(compiler): fix regexp to support firefox 31 #14082

merged 1 commit into from
Jan 24, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 24, 2017

fixes #14029
closes #13900

seems like firefox 31 interprets the "-" as a range here.

@vicb vicb added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2017
@alexeagle
Copy link
Contributor

alexeagle commented Jan 24, 2017 •
edited by mhevery
Loading

LGTM

Approved with PullApprove

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2017
@alxhub alxhub merged commit b2f9d56 into angular:master Jan 24, 2017
vicb added a commit to vicb/angular that referenced this pull request Jan 25, 2017
@vicb
docs(compiler): add comment to warn about regexp changes
d531ed6 
ref angular#14082
@vicb vicb mentioned this pull request Jan 25, 2017
Merged
alxhub pushed a commit that referenced this pull request Jan 25, 2017
@vicb @alxhub
docs(compiler): add comment to warn about regexp changes (#14106)
a733444 
ref #14082
alxhub pushed a commit that referenced this pull request Jan 25, 2017
@vicb @alxhub
fix(compiler): fix regexp to support firefox 31 (#14082)
bd2eecb 
fixes #14029
closes #13900
alxhub pushed a commit that referenced this pull request Jan 25, 2017
@vicb @alxhub
docs(compiler): add comment to warn about regexp changes (#14106)
6e36bb7 
ref #14082
@vicb vicb deleted the 0124-sel branch February 16, 2017 18:57
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
fix(compiler): fix regexp to support firefox 31 (angular#14082)
1873901 
fixes angular#14029
closes angular#13900
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
docs(compiler): add comment to warn about regexp changes (angular#14106)
183e294 
ref angular#14082
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RegExp bug since angular 2.4.2
4 participants
@vicb @alexeagle @alxhub @googlebot