Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): prevent ng-xi18n from emitting the compilation output #14115

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): prevent ng-xi18n from emitting the compilation output #14115

wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

Fixes #13567 by using the noEmit option of the TS compiler.

@marclaval marclaval added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 27, 2017
@marclaval marclaval requested a review from vicb January 29, 2017 19:53
@kschio
Copy link

kschio commented Feb 2, 2017

Hello @Mlaval,

thank you for taking your time to fix this!

Could you point me in the right direction how to fix this temporarily till the pull request was reviewed and the fix is released? Is there a way to apply the fix to a locally installed angular-cli package or would it require a rebuild?

Thanks again!

@marclaval
Copy link
Contributor Author

@kschio this PR relies on some changes which are only in Angular 4.0.0-beta.X
This commit to be precise: f816319

I'm afraid you'll have to wait for Angular 4

@mhevery
Copy link
Contributor

mhevery commented Feb 4, 2017

please amend the commit msg to add "fixes #13567" Thanks

@marclaval
Copy link
Contributor Author

@mhevery done

@mhevery mhevery closed this in e58d683 Feb 7, 2017
mhevery pushed a commit that referenced this pull request Feb 9, 2017
@marclaval @mhevery
fix(compiler-cli): prevent ng-xi18n from emitting the compilation out…
272829d 
…put (#14115)

fixes #13567

PR Close #14115
@ocombe ocombe mentioned this pull request Mar 1, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@marclaval
fix(compiler-cli): prevent ng-xi18n from emitting the compilation out…
19afbe7 
…put (angular#14115)

fixes angular#13567

PR Close angular#14115
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@marclaval @juleskremer
fix(compiler-cli): prevent ng-xi18n from emitting the compilation out…
5c2a9d8 
…put (angular#14115)

fixes angular#13567

PR Close angular#14115
@marclaval marclaval deleted the issue13567 branch December 11, 2017 10:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reopen: ng-xi18n tool compiles TypeScript files
5 participants
@marclaval @kschio @mhevery @vicb @googlebot