New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(aio): fix and enable e2e tests on Travis #14174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@@ -14,7 +15,7 @@ exports.config = { | |||
}, | |||
directConnect: true, | |||
baseUrl: 'http://localhost:4200/', | |||
framework: 'jasmine', | |||
framework: 'jasmine2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robwormald @hansl - was this scaffolded by the CLI?
looks like it was - https://github.com/angular/angular-cli/blob/916e9bd61773fce94c5867675842b0215e14e267/packages/angular-cli/blueprints/ng2/files/protractor.conf.js#L17
@hansl can we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found out that since angular/protractor@2bde92b, both jasmine
and jasmine2
point to Jasmne 2.x.
So, this change is not necessary for the version of Protractor that the cli is using.
cc @hansl, @IgorMinar, @robwormald
What's to change? Jasmine2? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
E2E tests where disabled, because they were failing on Travis.
What is the new behavior?
E2E tests are enabled and pass on Travis.
Does this PR introduce a breaking change? (check one with "x")
Other information:
Follow-up to #14102.