feat(core): view engine - support content projection #14209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
commented
Jan 31, 2017
| @@ -71,6 +71,7 @@ export interface NodeDef { | |||
| reverseChildIndex: number; | |||
| flags: NodeFlags; | |||
| parent: number; | |||
| ngContentIndex: number; | |||
tbosch
commented
Jan 31, 2017
| @@ -229,6 +232,8 @@ export enum QueryBindingType { | |||
| All | |||
| } | |||
|
|
|||
| export interface NgContentDef { index: number; } | |||
There was a problem hiding this comment.
add comment about the index vs ngContentIndex
vicb
approved these changes
Jan 31, 2017
tbosch
force-pushed
the
view_project
branch
2 times, most recently
from
a7eaa78
to
e33390b
Compare
|
@tbosch #4946 (comment) what do you think? |
|
@DzmitryShylovich Added a comment. I don't think we should do this now as it is a bit complicated. Also talked to @mhevery about it. |
|
@mhevery This marker code-review/pullapprove wrong (@vicb approved it) , @IgorMinar will look into it... |
pkozlowski-opensource
added
the
area: core
mhevery
pushed a commit
that referenced
this pull request
Feb 1, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is from #14197