Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pullapprove): fix file conditions #14214

Merged
merged 1 commit into from Feb 1, 2017

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 31, 2017

According to the docs, the correct keywords are include/exclude, without the trailing s.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The groups root and build-and-ci incorrectly use includes/excludes, which are apparently ignored by PullApprove and cause thoe two groups to match any file.

What is the new behavior?
The groups root and build-and-ci only match the intended files (TBD 馃槂).

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
@tbosch
Copy link
Contributor

tbosch commented Jan 31, 2017

Thanks! @IgorMinar FYI!

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2017
@IgorMinar IgorMinar merged commit 49fce37 into angular:master Feb 1, 2017
@IgorMinar
Copy link
Contributor

thanks for fixing my screw up!

mhevery pushed a commit that referenced this pull request Feb 1, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.

PR Close #14214
@gkalpak gkalpak deleted the gkalpak-patch-1 branch February 1, 2017 16:39
mhevery pushed a commit that referenced this pull request Feb 2, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
mhevery pushed a commit that referenced this pull request Feb 3, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 3, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
mhevery pushed a commit to mhevery/angular that referenced this pull request Feb 3, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
According to [the docs](http://docs.pullapprove.com/groups/conditions/), the correct keywords are `include`/`exclude`, without the trailing `s`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants