feat(core): view engine - integrate with ComponentFactory
#14237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
changed the title
ComponentFactoryComponentFactory
IgorMinar
approved these changes
Feb 2, 2017
|
Still needs review from @vicb |
tbosch
commented
Feb 2, 2017
| } | ||
| } | ||
|
|
||
| function renderDetachEmbeddedView(elementData: ElementData, view: ViewData) { | ||
| if (view.renderer) { |
tbosch
commented
Feb 2, 2017
|
|
||
| get element(): ElementRef { return <ElementRef>unimplemented(); } | ||
| get element(): ElementRef { return this._data.renderElement; } |
tbosch
commented
Feb 2, 2017
| get parentInjector(): Injector { | ||
| let view = this._view; | ||
| let parentIndex = view.def.nodes[this._elIndex].parent; | ||
| if (parentIndex == null) { |
There was a problem hiding this comment.
Use getDiParent here!
vicb
approved these changes
Feb 2, 2017
`ComponentFactory`s can now be created from a `ViewDefinitionFactory` via `RefFactory.createComponentFactory`. This commit also: - splits `Services` into `Refs` and `RootData` - changes `ViewState` into a bitmask - implements `ViewContainerRef.move` Part of angular#14013
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…14237) `ComponentFactory`s can now be created from a `ViewDefinitionFactory` via `RefFactory.createComponentFactory`. This commit also: - splits `Services` into `Refs` and `RootData` - changes `ViewState` into a bitmask - implements `ViewContainerRef.move` Part of angular#14013 PR Close angular#14237
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…14237) `ComponentFactory`s can now be created from a `ViewDefinitionFactory` via `RefFactory.createComponentFactory`. This commit also: - splits `Services` into `Refs` and `RootData` - changes `ViewState` into a bitmask - implements `ViewContainerRef.move` Part of angular#14013 PR Close angular#14237
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentFactorys can now be created from aViewDefinitionFactoryviaRefFactory.createComponentFactory.This commit also:
ServicesintoRefFactoryandRootDataViewStateinto a bitmaskViewContainerRef.move